-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Removing tech-preview header and updating documentation for retrievers and RRF #114810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM docs-wise
docs/reference/search/search-your-data/retrievers-overview.asciidoc
Outdated
Show resolved
Hide resolved
…iidoc Co-authored-by: Liam Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, but we need to be crystal clear about sub-searches & rrf rank. Those need to stay flagged as tech preview & we need to indicate that they will be removed.
[[rrf]] | ||
=== Reciprocal rank fusion | ||
|
||
preview::["This functionality is in technical preview and may be changed or removed in a future release. The syntax will likely change before GA. Elastic will work to fix any issues, but features in technical preview are not subject to the support SLA of official GA features."] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to make sure that we CLEARLY communicate that rank: rrf
is still tech preview and will be removed. I am not sure what things link to this doc page, but we need to be absolutely clear about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/reference/search/search-your-data/retrievers-overview.asciidoc
Outdated
Show resolved
Hide resolved
…iidoc Co-authored-by: Benjamin Trent <[email protected]>
…csearch into updating_docs_for_rrf_ga
@elasticmachine update branch |
💚 Backport successful
|
…s and RRF (#114810) (#114875) Co-authored-by: Elastic Machine <[email protected]>
Now that the rework of RRF and retrievers in general has been merged, it's probably time to remove the tech-preview header from the documentation in time for
8.16
and mark the feature as GA.