-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Removing tech-preview header and updating documentation for retrievers and RRF #114810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4e7f594
Removing tech-preview header and documentation for retrievers and RRF
pmpailis bb8f7dd
updating docs
pmpailis 5bf0511
Update docs/reference/search/search-your-data/retrievers-overview.asc…
pmpailis 89b8bc8
Update docs/reference/search/search-your-data/retrievers-overview.asc…
pmpailis 58dd18c
adding rrf with semantic_reranker example
pmpailis 22fa49e
Merge branch 'updating_docs_for_rrf_ga' of github.com:pmpailis/elasti…
pmpailis 6e8843a
removing min_score as an unsupported option
pmpailis 4b16c0f
Merge branch 'main' into updating_docs_for_rrf_ga
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to make sure that we CLEARLY communicate that
rank: rrf
is still tech preview and will be removed. I am not sure what things link to this doc page, but we need to be absolutely clear about that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All references to docs have been removed when we introduced the rrf retriever here. Should we add a warning header that
rank: rrf
is a now-deprecated option?I've also opened this PR to add deprecation headers when using
rank: rrf
and/orsub_searches