Fix setOnce in EmbeddingRequestChunker #114900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
jan-elastic
commented
Oct 16, 2024
| var errorResult = new ErrorChunkedInferenceResults(e); | ||
| for (var pos : positions) { | ||
| errors.setOnce(pos.inputIndex(), errorResult); | ||
| errors.set(pos.inputIndex(), errorResult); |
There was a problem hiding this comment.
Multiple chunks of the same input text can fail. In that case pos.inputIndex is the same and setOnce fails, leading to Elasticsearch crashing.
jan-elastic
added
:ml
|
Pinging @elastic/ml-core (Team:ML) |
jan-elastic
added
the
auto-backport
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
jan-elastic
added a commit
that referenced
this pull request
Oct 16, 2024
This was referenced Oct 16, 2024
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Oct 16, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 16, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.