Skip to content

Fix setOnce in EmbeddingRequestChunker #114900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix setOnce in EmbeddingRequestChunker #114900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nce/src/main/java/org/elasticsearch/xpack/inference/chunking/EmbeddingRequestChunker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ private ElasticsearchStatusException unexpectedResultTypeException(String got, S
public void onFailure(Exception e) {
var errorResult = new ErrorChunkedInferenceResults(e);
for (var pos : positions) {
errors.setOnce(pos.inputIndex(), errorResult);
errors.set(pos.inputIndex(), errorResult);
Copy link
Contributor Author

@jan-elastic jan-elastic Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple chunks of the same input text can fail. In that case pos.inputIndex is the same and setOnce fails, leading to Elasticsearch crashing.

}

if (resultCount.incrementAndGet() == totalNumberOfRequests) {
Expand Down
Loading