Add num docs and size to logsdb telemetry #116128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
logsdb-usage-stats
branch
from
5afaf6d to
cb90135
Compare
|
Hi @dnhatn, I've created a changelog YAML for you. |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
reviewed
Nov 4, 2024
| } | ||
|
|
||
| public static class IndexStats implements Writeable { | ||
| private long numDocs; |
There was a problem hiding this comment.
Fields need to be non-final for the add method, which combines stats across shards and nodes.
| } | ||
|
|
||
| @Override | ||
| protected NodeResponse nodeOperation(NodeRequest request, Task task) { |
There was a problem hiding this comment.
Do you think there is an easy way to reuse the logic in IndicesStatsCache#internalGetIndicesStats()? I think it is the same logic.
I suspect we don't want the caching behaviour that IndicesMetrics has (because this should be invoked often), otherwise we could think of reusing it.
dnhatn
added
the
auto-backport
|
@martijnvg This is ready again. Can you please take another look? Thank you! |
|
Thanks Martijn! |
💚 Backport successful
|
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Nov 5, 2024
Follow-up on elastic#115994 to add telemetry for the total number of documents and size in bytes of logsdb indices. Relates elastic#115994
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Nov 5, 2024
Follow-up on elastic#115994 to add telemetry for the total number of documents and size in bytes of logsdb indices. Relates elastic#115994
dnhatn
added a commit
that referenced
this pull request
Nov 7, 2024
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Follow-up on elastic#115994 to add telemetry for the total number of documents and size in bytes of logsdb indices. Relates elastic#115994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #115994 to add telemetry for the total number of documents and size in bytes of logsdb indices.
Relates #115994