Add num docs and size to logsdb telemetry #116128
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| pr: 116128 | ||
| summary: Add num docs and size to logsdb telemetry | ||
| area: Logs | ||
| type: enhancement | ||
| issues: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,230 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| package org.elasticsearch.action.admin.cluster.node.stats; | ||
|
|
||
| import org.apache.lucene.store.AlreadyClosedException; | ||
| import org.elasticsearch.action.ActionType; | ||
| import org.elasticsearch.action.FailedNodeException; | ||
| import org.elasticsearch.action.support.ActionFilters; | ||
| import org.elasticsearch.action.support.nodes.BaseNodeResponse; | ||
| import org.elasticsearch.action.support.nodes.BaseNodesRequest; | ||
| import org.elasticsearch.action.support.nodes.BaseNodesResponse; | ||
| import org.elasticsearch.action.support.nodes.TransportNodesAction; | ||
| import org.elasticsearch.cluster.ClusterName; | ||
| import org.elasticsearch.cluster.node.DiscoveryNode; | ||
| import org.elasticsearch.cluster.routing.ShardRouting; | ||
| import org.elasticsearch.cluster.service.ClusterService; | ||
| import org.elasticsearch.common.io.stream.StreamInput; | ||
| import org.elasticsearch.common.io.stream.StreamOutput; | ||
| import org.elasticsearch.common.io.stream.Writeable; | ||
| import org.elasticsearch.index.IndexMode; | ||
| import org.elasticsearch.index.IndexService; | ||
| import org.elasticsearch.index.shard.DocsStats; | ||
| import org.elasticsearch.index.shard.IllegalIndexShardStateException; | ||
| import org.elasticsearch.index.shard.IndexShard; | ||
| import org.elasticsearch.indices.IndicesService; | ||
| import org.elasticsearch.injection.guice.Inject; | ||
| import org.elasticsearch.tasks.Task; | ||
| import org.elasticsearch.threadpool.ThreadPool; | ||
| import org.elasticsearch.transport.TransportRequest; | ||
| import org.elasticsearch.transport.TransportService; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.EnumMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public final class IndexModeStatsActionType extends ActionType<IndexModeStatsActionType.StatsResponse> { | ||
| public static final IndexModeStatsActionType TYPE = new IndexModeStatsActionType(); | ||
|
|
||
| private IndexModeStatsActionType() { | ||
| super("cluster:monitor/nodes/index_mode_stats"); | ||
| } | ||
|
|
||
| public static class StatsRequest extends BaseNodesRequest { | ||
| public StatsRequest(String[] nodesIds) { | ||
| super(nodesIds); | ||
| } | ||
|
|
||
| public StatsRequest(DiscoveryNode... concreteNodes) { | ||
| super(concreteNodes); | ||
| } | ||
| } | ||
|
|
||
| public static class IndexStats implements Writeable { | ||
| private long numDocs; | ||
| private long sizeInBytes; | ||
|
|
||
| public IndexStats() {} | ||
|
|
||
| IndexStats(StreamInput in) throws IOException { | ||
| this.numDocs = in.readVLong(); | ||
| this.sizeInBytes = in.readVLong(); | ||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeVLong(numDocs); | ||
| out.writeVLong(sizeInBytes); | ||
| } | ||
|
|
||
| public long numDocs() { | ||
| return numDocs; | ||
| } | ||
|
|
||
| public long sizeInBytes() { | ||
| return sizeInBytes; | ||
| } | ||
|
|
||
| public void add(IndexStats other) { | ||
| this.numDocs += other.numDocs; | ||
| this.sizeInBytes += other.sizeInBytes; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "IndexStats{" + "numDocs=" + numDocs + ", sizeInBytes=" + sizeInBytes + '}'; | ||
| } | ||
| } | ||
|
|
||
| public static class StatsResponse extends BaseNodesResponse<NodeResponse> { | ||
| StatsResponse(ClusterName clusterName, List<NodeResponse> nodes, List<FailedNodeException> failures) { | ||
| super(clusterName, nodes, failures); | ||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| assert false : "must be local"; | ||
| throw new UnsupportedOperationException("must be local"); | ||
| } | ||
|
|
||
| @Override | ||
| protected List<NodeResponse> readNodesFrom(StreamInput in) throws IOException { | ||
| assert false : "must be local"; | ||
| throw new UnsupportedOperationException("must be local"); | ||
| } | ||
|
|
||
| @Override | ||
| protected void writeNodesTo(StreamOutput out, List<NodeResponse> nodes) throws IOException { | ||
| assert false : "must be local"; | ||
| throw new UnsupportedOperationException("must be local"); | ||
| } | ||
|
|
||
| public Map<IndexMode, IndexStats> stats() { | ||
| final Map<IndexMode, IndexStats> stats = new EnumMap<>(IndexMode.class); | ||
| for (IndexMode mode : IndexMode.values()) { | ||
| stats.put(mode, new IndexStats()); | ||
| } | ||
| for (NodeResponse node : getNodes()) { | ||
| for (Map.Entry<IndexMode, IndexStats> e : node.stats.entrySet()) { | ||
| stats.get(e.getKey()).add(e.getValue()); | ||
| } | ||
| } | ||
| return stats; | ||
| } | ||
| } | ||
|
|
||
| public static class NodeRequest extends TransportRequest { | ||
| NodeRequest() { | ||
|
|
||
| } | ||
|
|
||
| NodeRequest(StreamInput in) throws IOException { | ||
| super(in); | ||
| } | ||
| } | ||
|
|
||
| public static class NodeResponse extends BaseNodeResponse { | ||
| private final Map<IndexMode, IndexStats> stats; | ||
|
|
||
| NodeResponse(DiscoveryNode node, Map<IndexMode, IndexStats> stats) { | ||
| super(node); | ||
| this.stats = stats; | ||
| } | ||
|
|
||
| NodeResponse(StreamInput in, DiscoveryNode node) throws IOException { | ||
| super(in, node); | ||
| stats = in.readMap(IndexMode::readFrom, IndexStats::new); | ||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| super.writeTo(out); | ||
| out.writeMap(stats, (o, m) -> IndexMode.writeTo(m, o), (o, s) -> s.writeTo(o)); | ||
| } | ||
| } | ||
|
|
||
| public static class TransportAction extends TransportNodesAction<StatsRequest, StatsResponse, NodeRequest, NodeResponse, Void> { | ||
| private final ClusterService clusterService; | ||
| private final IndicesService indicesService; | ||
|
|
||
| @Inject | ||
| public TransportAction( | ||
| ClusterService clusterService, | ||
| TransportService transportService, | ||
| IndicesService indicesService, | ||
| ActionFilters actionFilters | ||
| ) { | ||
| super( | ||
| TYPE.name(), | ||
| clusterService, | ||
| transportService, | ||
| actionFilters, | ||
| NodeRequest::new, | ||
| transportService.getThreadPool().executor(ThreadPool.Names.MANAGEMENT) | ||
| ); | ||
| this.clusterService = clusterService; | ||
| this.indicesService = indicesService; | ||
| } | ||
|
|
||
| @Override | ||
| protected StatsResponse newResponse(StatsRequest request, List<NodeResponse> nodeResponses, List<FailedNodeException> failures) { | ||
| return new StatsResponse(ClusterName.DEFAULT, nodeResponses, failures); | ||
| } | ||
|
|
||
| @Override | ||
| protected NodeRequest newNodeRequest(StatsRequest request) { | ||
| return new NodeRequest(); | ||
| } | ||
|
|
||
| @Override | ||
| protected NodeResponse newNodeResponse(StreamInput in, DiscoveryNode node) throws IOException { | ||
| return new NodeResponse(in, node); | ||
| } | ||
|
|
||
| @Override | ||
| protected NodeResponse nodeOperation(NodeRequest request, Task task) { | ||
|
There was a problem hiding this comment. Do you think there is an easy way to reuse the logic in I suspect we don't want the caching behaviour that |
||
| final Map<IndexMode, IndexStats> stats = new EnumMap<>(IndexMode.class); | ||
| for (IndexMode mode : IndexMode.values()) { | ||
| stats.put(mode, new IndexStats()); | ||
| } | ||
| for (IndexService indexService : indicesService) { | ||
| for (IndexShard indexShard : indexService) { | ||
| if (indexShard.isSystem()) { | ||
| continue; // skip system indices | ||
| } | ||
| final ShardRouting shardRouting = indexShard.routingEntry(); | ||
| final IndexMode indexMode = indexShard.indexSettings().getMode(); | ||
| final IndexStats indexStats = stats.get(indexMode); | ||
| try { | ||
| if (shardRouting.primary() && shardRouting.recoverySource() == null) { | ||
| final DocsStats docStats = indexShard.docStats(); | ||
| indexStats.numDocs += docStats.getCount(); | ||
| indexStats.sizeInBytes += docStats.getTotalSizeInBytes(); | ||
| } | ||
| } catch (IllegalIndexShardStateException | AlreadyClosedException ignored) { | ||
| // ignored | ||
| } | ||
| } | ||
| } | ||
| return new NodeResponse(clusterService.localNode(), stats); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make fields final?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fields need to be non-final for the
addmethod, which combines stats across shards and nodes.