-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS][101] Aggregations quickstart tutorial #116251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start!
} | ||
} | ||
---- | ||
// TEST[skip:Using Kibana sample data] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to prepopulate some of this, and just stub in the example values we want in the test. That way CI will break if these ever change and no longer work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first draft, I like the journey you lead the user on, it has good flow :)
} | ||
} | ||
---- | ||
// TEST[skip:Using Kibana sample data] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
|
||
Refer to the <<search-aggregations,aggregations reference>> for more details on all available aggregation types. | ||
|
||
//TODO add relevant links judiciously No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see we agree about the need for lots of links to supporting content. Of course, I see this after leaving lots of comments about where links are needed 🫠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I should have been clearer about that in the PR description, my bad 🙏
* Standardize on "eCommerce" capitalization throughout * Add cross-references to relevant documentation * Improve technical explanations and callouts * Clarify requirements section organization * Add more context around distributed search behavior * Fix bullet point consistency * Add missing section introductions * Enhance date format and interval explanations
Is there any reason to add scripts in aggregations or metadata? I only ask as we do talk about those in the serverless aggregation content. Or is that outside of basics for aggregations? |
@leemthompo Sorry for the delay in response, catching back up after PTO. I think the content here is good, we just need to flesh out some of the example responses and tests 👍 |
@kderusso @Mikep86 this one had to sit on the sidelines for a while, will have to punt on snippet testing for moment due to bandwidth, but this shouldn't block publishing. I'll do another polish pass tomorrow to make sure all the annotations make sense, otherwise hopefully this should be ready to go. |
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock because this is a good guide, but it would be nice to get tests working in a followup.
💔 Backport failed
You can use sqren/backport to manually backport by running |
(cherry picked from commit 56e1ca5) # Conflicts: # docs/reference/quickstart/index.asciidoc
(cherry picked from commit 56e1ca5) # Conflicts: # docs/reference/quickstart/index.asciidoc
(cherry picked from commit 56e1ca5) # Conflicts: # docs/reference/quickstart/index.asciidoc
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 56e1ca5) # Conflicts: # docs/reference/quickstart/index.asciidoc
Aggregations tutorial using Kibana sample e-commerce data
TODO:
👁️🗨️ URL preview