-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ES|QL] Add support for byte_length scalar function #116591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview: |
e250ba1
to
3549756
Compare
Hi @GalLalouche, I've created a changelog YAML for you. |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
reviewed
Nov 11, 2024
...src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/ByteLength.java
Show resolved
Hide resolved
💚 CLA has been signed |
nik9000
approved these changes
Nov 11, 2024
f0fa476
to
e9bd6eb
Compare
craigtaverner
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; but I have some suggestions that might be worth taking a look at.
x-pack/plugin/esql/qa/testFixtures/src/main/resources/eval.csv-spec
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/BitLength.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/ByteLength.java
Show resolved
Hide resolved
...sql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/Length.java
Show resolved
Hide resolved
x-pack/plugin/esql/qa/testFixtures/src/main/resources/eval.csv-spec
Outdated
Show resolved
Hide resolved
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
Also added documentation and examples for BIT_LENGTH and LENGTH regarding unicode.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Nov 13, 2024
Also added documentation and examples for BIT_LENGTH and LENGTH regarding unicode.
This was referenced Nov 13, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 13, 2024
Also added documentation and examples for BIT_LENGTH and LENGTH regarding unicode.
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 14, 2024
Also added documentation and examples for BIT_LENGTH and LENGTH regarding unicode.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Nov 14, 2024
GalLalouche
added a commit
that referenced
this pull request
Nov 14, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Also added documentation and examples for BIT_LENGTH and LENGTH regarding unicode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
>feature
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ES|QL] Add support for
byte_length
scalar function, which is similar tobit_length
, except it counts bytes and not bits.