-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Address and remove all occurrences of the Java annotation @UpdateForV9 (ES-9378) #119105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
public static final String THREAD_POOL_METRIC_NAME_REJECTED = ".threads.rejected.total"; | ||
|
||
public enum ThreadPoolType { | ||
@Deprecated(forRemoval = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR for 8.x: #118492
super(NAME); | ||
} | ||
|
||
@UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA) // this can be replaced with TransportRequest.Empty in v9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slack thread confirming that we don't need it anymore: https://elastic.slack.com/archives/C8UUBNASY/p1733330314431679
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine, but they still seem unrelated and the PR title is not descriptive of the actual change. Can you change the title to a meaningful description, or further split out these changes so that the git log clearly shows what changed?
public static String TEST_SYSTEM_INDEX_PATTERN = ".test*"; | ||
private static final IndexVersion TEST_OLD_VERSION = IndexVersion.fromId(6000099); | ||
// Version just before MINIMUM_COMPATIBLE in order to check that UpgradeStatus.MIGRATION_NEEDED is set correctly | ||
private static final IndexVersion TEST_OLD_VERSION = IndexVersion.fromId(IndexVersions.MINIMUM_COMPATIBLE.id() - 100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 100? Although in the past IndexVersion
s were stepped by 100 because they were just Version
, it seems like this test would be more future proof if we subtract just 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it did this because IndexVersions stepped by 100, changed to 1
@rjernst I've extracted the changes related to ThreadPools into a separate PR ([#119941]). The remaining changes, while indeed unrelated, are quite small - mostly uncommenting existing code or minor test updates. I don't think it would be worth splitting them further into multiple PRs containing 1-2 line adjustments without any significant impact on product behavior. I've improved the PR description to clarify the changes better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please also update the PR title since that will be part of the commit message.
…stic#119105) Restore contentTypeVersion check in RestCompatibleVersionHelper which was commented out when RestApiVersion.V_9 was introduced, update tests to work correctly with v9 version and remove @UpdateForV9 annotation that is no longer applicable
Restore contentTypeVersion check in
RestCompatibleVersionHelper
which was commented out whenRestApiVersion.V_9
was introduced, update tests to work correctly with v9 version and remove @UpdateForV9 annotation that is no longer applicable