-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Initial support for TEXT fields in LOOKUP JOIN condition #119473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
a4f3b5e
c1744c9
8eb6554
69572e5
417d3df
e799ef9
772659d
93779f9
cbcd532
0146742
e327808
77fc5bf
2b2f0dc
4380656
6a56279
3491006
d5d7cee
879ecd4
724153c
863cfc9
26a76f9
f0ce28a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -80,7 +80,8 @@ protected String getRequiredPrivilege() { | |||||||
|
|
||||||||
| private static void validateTypes(DataType inputDataType, MappedFieldType fieldType) { | ||||||||
| // TODO: consider supporting implicit type conversion as done in ENRICH for some types | ||||||||
| if (fieldType.typeName().equals(inputDataType.typeName()) == false) { | ||||||||
| String typeName = fieldType.typeName().equals("text") ? DataType.KEYWORD.typeName() : fieldType.typeName(); | ||||||||
| if (typeName.equals(inputDataType.noText().typeName()) == false) { | ||||||||
|
||||||||
| String typeName = fieldType.typeName().equals("text") ? DataType.KEYWORD.typeName() : fieldType.typeName(); | |
| if (typeName.equals(inputDataType.noText().typeName()) == false) { | |
| if (Objects.equals(DataType.fromTypeName(fieldType.typeName()).noText(), inputDataType.noText()) == false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually thinking of deleting this method entirely, since it is shadowed by the newer validation happening in the Validator. In the current draft I fixed both methods, but in reality we only need the one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly exists to show that matching against text fields "doesn't work like you think it does" in the ENRICH infrastructure we've borrowed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've deleted this now (or rather I'm throwing an exception, but might want to delete that too), and instead try get the planner to use an underlying KEYWORD sub-field, if it exists, using fa.exactAttribute().