- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
Add index_options to semantic_text field mappings #119967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            kderusso
  merged 96 commits into
  elastic:main
from
kderusso:kderusso/semantic-text-index-options
  
      
      
   
  Jun 17, 2025 
      
    
  
     Merged
                    Changes from 92 commits
      Commits
    
    
            Show all changes
          
          
            96 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      67b7623
              
                Add index_options parameter to semantic_text field mapping
              
              
                kderusso d822301
              
                Cleanup & tests
              
              
                kderusso 251d22c
              
                Update docs
              
              
                kderusso 8724cce
              
                Update docs/changelog/119967.yaml
              
              
                kderusso 6445a44
              
                Merge branch 'main' into kderusso/semantic-text-index-options
              
              
                kderusso 26de9d3
              
                Merge branch 'main' into kderusso/semantic-text-index-options
              
              
                kderusso 948d596
              
                Addressed some PR feedbak
              
              
                kderusso 860ebc4
              
                Update yaml tests
              
              
                kderusso 07284f5
              
                Refactoring
              
              
                kderusso 3c1f6e1
              
                Cleanup
              
              
                kderusso b4f45ea
              
                Merge main into kderusso/semantic-text-index-options
              
              
                kderusso 5d2f48b
              
                Fix some tests
              
              
                kderusso 47b4e23
              
                Hack in inferring text_embedding task type from index options
              
              
                kderusso 6f72f00
              
                [CI] Auto commit changes from spotless
              
              
                 1602b09
              
                Fix error inferring model settings
              
              
                kderusso c7f99c1
              
                Merge branch 'main' into kderusso/semantic-text-index-options
              
              
                kderusso d9db3b4
              
                Update docs
              
              
                kderusso 4151cca
              
                Update tests
              
              
                kderusso d96dadc
              
                Update docs/reference/mapping/types/semantic-text.asciidoc
              
              
                kderusso 701dab5
              
                Address some minor PR feedback
              
              
                kderusso 453f132
              
                Remove partial model_settings with inferred task type
              
              
                kderusso e7744a7
              
                Cleanup
              
              
                kderusso 14fde82
              
                Remove unnecessary changes
              
              
                kderusso 53ab0ac
              
                Merge from main
              
              
                kderusso 59bde7d
              
                Fix errors from merge
              
              
                kderusso 0ce700e
              
                [CI] Auto commit changes from spotless
              
              
                 73f7017
              
                Cleanup
              
              
                kderusso 0ab598c
              
                Checkpoint, saving changes before merge
              
              
                kderusso 560d6c2
              
                Merge from main
              
              
                kderusso 498e6c9
              
                Update parsing
              
              
                kderusso 228b308
              
                [CI] Auto commit changes from spotless
              
              
                 5ebb84c
              
                Stash changes
              
              
                kderusso 8ea0167
              
                Merge from main
              
              
                kderusso e41022e
              
                Fix compile errors
              
              
                kderusso 959b1d3
              
                [CI] Auto commit changes from spotless
              
              
                 8701954
              
                Cleanup error
              
              
                kderusso fe63309
              
                fix test
              
              
                kderusso 8db6942
              
                fix test
              
              
                kderusso 7affc70
              
                Fix another test
              
              
                kderusso df06595
              
                A bit of cleanup
              
              
                kderusso 5bf9d2f
              
                Merge from main
              
              
                kderusso 34b2153
              
                Fix tests
              
              
                kderusso be4136b
              
                Spotless
              
              
                kderusso 216f8bc
              
                Respect index options if set over defaults
              
              
                kderusso 651fede
              
                Cleanup
              
              
                kderusso 3abdc75
              
                [CI] Auto commit changes from spotless
              
              
                 27b4f9e
              
                Support updating to compatible versions, add some cleanup and validation
              
              
                kderusso 9fb403b
              
                Merge from main
              
              
                kderusso 7b4d424
              
                Remove test that can't be done here - needs to be unit test
              
              
                kderusso 4b11083
              
                Add validation
              
              
                kderusso d65c011
              
                Cleanup
              
              
                kderusso 4f933fc
              
                Fix some yaml tests
              
              
                kderusso 07829e8
              
                Merge from main
              
              
                kderusso 1d524b2
              
                [CI] Auto commit changes from spotless
              
              
                 f9127eb
              
                Happy path early index validation works now; edge cases surrounding d…
              
              
                kderusso 9912426
              
                Always emit index options, even when using defaults
              
              
                kderusso dca3e54
              
                Minor cleanup
              
              
                kderusso 7a5a29a
              
                Fix test compilation failures
              
              
                kderusso 279d4c2
              
                Fix some tests
              
              
                kderusso a452d8e
              
                Continue to iterate on test failures
              
              
                kderusso 9a0ca94
              
                Remove index options from inference field metadata as it is only need…
              
              
                kderusso 3e1c941
              
                Fix some tests
              
              
                kderusso e9bfdc8
              
                Remove transport version, no longer needed
              
              
                kderusso 40ed2fd
              
                Fix yaml tests
              
              
                kderusso 78bf4a2
              
                Add tests
              
              
                kderusso 2cc4191
              
                Merge main
              
              
                kderusso c909699
              
                IndexOptions don't need to implement Writeable
              
              
                kderusso 64b787f
              
                [CI] Auto commit changes from spotless
              
              
                 bad0585
              
                Refactor - move SemanticTextIndexOptions
              
              
                kderusso 3036adf
              
                Remove writeable
              
              
                kderusso 66d65b5
              
                Move index_options parsing to semantic text field mapper
              
              
                kderusso 2152926
              
                Cleanup
              
              
                kderusso 26393a5
              
                Fix test compilation issue
              
              
                kderusso 9390356
              
                Cleanup
              
              
                kderusso a1aaffc
              
                Remove whitespace
              
              
                kderusso f6d58a1
              
                Remove writeables from index options
              
              
                kderusso 2ef8b1d
              
                Disable merging null options?
              
              
                kderusso b044184
              
                Add docs
              
              
                kderusso aa12294
              
                [CI] Auto commit changes from spotless
              
              
                 1c4104a
              
                Revert "Disable merging null options?"
              
              
                kderusso 1886969
              
                Merge update from main
              
              
                kderusso 7c23a7c
              
                Remove default serialization
              
              
                kderusso aac9ab7
              
                Merge from main
              
              
                kderusso b08e2a1
              
                Include default index option type to defaults
              
              
                kderusso 9e247c9
              
                [CI] Auto commit changes from spotless
              
              
                 3be5eda
              
                Go back to allowing null updateS
              
              
                kderusso c94955e
              
                Cleanup
              
              
                kderusso e993671
              
                Fix validation error
              
              
                kderusso b843047
              
                Revert "Include default index option type to defaults"
              
              
                kderusso aedfafe
              
                Update tests
              
              
                kderusso 062eeac
              
                Revert "Update tests"
              
              
                kderusso 65a3d02
              
                Better fix for null inputs
              
              
                kderusso fa22c56
              
                Merge branch 'main' into kderusso/semantic-text-index-options
              
              
                kderusso 57bd949
              
                Remove redundant merge validation
              
              
                kderusso 2db090c
              
                Merge branch 'main' into kderusso/semantic-text-index-options
              
              
                kderusso a6c04a5
              
                Merge branch 'main' into kderusso/semantic-text-index-options
              
              
                kderusso File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| pr: 119967 | ||
| summary: Add `index_options` to `semantic_text` field mappings | ||
| area: Mapping | ||
| type: enhancement | ||
| issues: [ ] | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.