Simplify and speedup handling of AliasFilter logic in search #120446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the map is needlessly expensive, we can just the empty filter as a default.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Contributor
Author
|
hmpf the BwC here is really tricky, draft for now, no need to review |
Contributor
Author
|
salvaged what still applies from this in #127240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the map is needlessly expensive, we can just use the empty filter as a default throughout the logic and save a lot of indirection.
This is a reasonable simplification + memory saving now and a critical performance improvement once #118490 lands.
Also, made the
buildAliasFiltermethod faster on the hot path without aliases.