Backport moving scoring in ES|QL out of snapshot into 8.x #120905
Conversation
* Move scoring in ES|QL out of snapshot --------- Co-authored-by: Carlos Delgado <[email protected]> (cherry picked from commit 1b1296e)
…20538) * Revert unwanted ES|QL lexer changes from PR elastic#120354 * Update docs/changelog/120538.yaml (cherry picked from commit 04b5b7a)
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @tteofili, I've created a changelog YAML for you. |
There was a problem hiding this comment.
I think we should do some cleaning of the changelog YAMLs, as otherwise we'll get some release notes that users could be confused about.
Just realising it now, we can probably remove some of the guards in tests:
assumeTrue("'METADATA _score' is disabled", EsqlCapabilities.Cap.METADATA_SCORE.isEnabled());, for example in PhysicalPlanOptimizerTests.
That can be done as a follow up. Sorry for coming up with this so late in the process.
There was a problem hiding this comment.
I don't think any of these changelog should be added? We already should have the changelog for the scoring change, the others should not be needed (this should be a >non-issue IMO)
There was a problem hiding this comment.
thanks @carlosdelest , very good points !
There was a problem hiding this comment.
added #120940 to remove the mentioned assertions in tests
…earch into esql_scoring_nosnap_8x
3 participants
see #120354