Rename environment dir accessors #121803
Merged
Rename environment dir accessors #121803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node environment has many paths. The accessors for these currently use a "file" suffix, but they are always directories. This commit renames the accessors to make it clear these paths are directories.
rjernst
added
:Core/Infra/Core
|
Note that although the change is large, it was completely mechanical, renaming with IntelliJ. |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
reviewed
Feb 5, 2025
| assertEquals(actual.tmpFile(), expected.tmpFile(), "tmpFile"); | ||
| assertEquals(actual.dataDirs(), expected.dataDirs(), "dataFiles"); | ||
| assertEquals(actual.repoDirs(), expected.repoDirs(), "repoFiles"); | ||
| assertEquals(actual.configDir(), expected.configDir(), "configFile"); |
There was a problem hiding this comment.
I suppose these strings ought to have been changed too.
|
This is a great idea. This always added a small amount of mental friction. |
elasticsearchmachine
added
the
serverless-linked
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 5, 2025
The node environment has many paths. The accessors for these currently use a "file" suffix, but they are always directories. This commit renames the accessors to make it clear these paths are directories.
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 5, 2025
The node environment has many paths. The accessors for these currently use a "file" suffix, but they are always directories. This commit renames the accessors to make it clear these paths are directories.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 5, 2025
The node environment has many paths. The accessors for these currently use a "file" suffix, but they are always directories. This commit renames the accessors to make it clear these paths are directories.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Rename environment dir accessors (#121803) The node environment has many paths. The accessors for these currently use a "file" suffix, but they are always directories. This commit renames the accessors to make it clear these paths are directories. * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Rename environment dir accessors (#121803) The node environment has many paths. The accessors for these currently use a "file" suffix, but they are always directories. This commit renames the accessors to make it clear these paths are directories. * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node environment has many paths. The accessors for these currently use a "file" suffix, but they are always directories. This commit renames the accessors to make it clear these paths are directories.