- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
Don't attempt to install modules into test cluster more than once #121833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            mark-vieira
  merged 1 commit into
  elastic:main
from
mark-vieira:extended-modules-with-overrides-fix
  
      
      
   
  Feb 5, 2025 
      
    
                
     Merged
            
            Don't attempt to install modules into test cluster more than once #121833
                    mark-vieira
  merged 1 commit into
  elastic:main
from
mark-vieira:extended-modules-with-overrides-fix
  
      
      
   
  Feb 5, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Pinging @elastic/es-delivery (Team:Delivery)  | 
    
              
                    rjernst
  
              
              approved these changes
              
                  
                    Feb 5, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
    
  mark-vieira 
      added a commit
        to mark-vieira/elasticsearch
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
      
  
    
      
    
  
…astic#121833) (cherry picked from commit 56cac1b)
  This was referenced Feb 6, 2025 
      
    
  mark-vieira 
      added a commit
        to mark-vieira/elasticsearch
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
      
  
    
      
    
  
…astic#121833) (cherry picked from commit 56cac1b)
    
  mark-vieira 
      added a commit
        to mark-vieira/elasticsearch
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
      
  
    
      
    
  
…astic#121833) (cherry picked from commit 56cac1b)
    
  mark-vieira 
      added a commit
        to mark-vieira/elasticsearch
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
      
  
    
      
    
  
…astic#121833) (cherry picked from commit 56cac1b)
    
  mark-vieira 
      added a commit
        to mark-vieira/elasticsearch
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
      
  
    
      
    
  
…astic#121833) (cherry picked from commit 56cac1b)
          💚 All backports created successfully
 Questions ?Please refer to the Backport tool documentation  | 
    
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
  
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
  
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
  
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
  
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    :Delivery/Build
  Build or test infrastructure 
  
    Team:Delivery
  Meta label for Delivery team 
  
    >test
  Issues or PRs that are addressing/adding tests 
  
    v8.19.0
  
    v9.0.1
  
    v9.1.0
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
When installing modules that extend other modules, it's possible to install the same module multiple times. This can cause issues if overrides are specified for that module. Avoid doing this by skipping module installation for extended modules if they've already been installed.