Fold PlainShardIterator into ShardIterator #121893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShardIterator is an interface with a single implementation called PlainShardIterator. This commit makes it a concrete final class and folds its only implementation into it.
javanna
added
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
Team:Distributed Indexing
tlrx
approved these changes
Feb 6, 2025
server/src/main/java/org/elasticsearch/cluster/routing/ShardIterator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/routing/ShardIterator.java
Outdated
Show resolved
Hide resolved
javanna
added
the
auto-backport
|
Thanks, both of you Armin and Tanguy! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShardIterator is an interface with a single implementation called PlainShardIterator. This commit makes it a concrete final class and folds its only implementation into it.