Enforce aggs interface #121898
Merged
Enforce aggs interface #121898
+179
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
force-pushed
the
enforce_interface
branch
from
57d34e4 to
b9ce9db
Compare
elasticsearchmachine
added
the
needs:triage
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
removed
the
needs:triage
ivancea
approved these changes
Feb 10, 2025
| declarationType, | ||
| // This should be more restrictive and require org.elasticsearch.compute.aggregation.AggregatorState | ||
| requirePrimitiveOrImplements(elements, Types.RELEASABLE), | ||
| requirePrimitiveOrImplements(elements, ClassName.get("org.elasticsearch.compute.aggregation", "AggregatorState")), |
There was a problem hiding this comment.
Should we move those to the Types constants class? To follow what we do with other types.
Same with the GroupingAggregatorState one
nik9000
approved these changes
Feb 10, 2025
| declarationType, | ||
| // This should be more restrictive and require org.elasticsearch.compute.aggregation.AggregatorState | ||
| requirePrimitiveOrImplements(elements, Types.RELEASABLE), | ||
| requirePrimitiveOrImplements(elements, ClassName.get("org.elasticsearch.compute.aggregation", "AggregatorState")), |
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Feb 12, 2025
(cherry picked from commit a57b985)
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates code generation to require that State implements AggregatorState/GroupingAggregatorState as we rely on their methods in generated code.
All aggs states are not explicitly implement them.