[9.0] backport various aggs code gen improvements #122360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`combineValueCount` is described as something that might no longer be needed and has zero actual usages. Removing it in order to simplify code generation. (cherry picked from commit e5ea00a)
(cherry picked from commit 17d25ad)
elastic#121749) (cherry picked from commit 7deaacd)
(cherry picked from commit a36b327)
(cherry picked from commit a57b985)
idegtiarenko
added
>non-issue
backport
Team:Analytics
nik9000
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports following changes to 9.0 branch:
combineValueCountfrom code generation #121637I believe it will be faster to backport them all in one change rather than do it per PR.
I would like to have review/approval to confirm we want to backport all of it.