EQL: fix JOIN command validation (not supported) #122011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>bug
:Analytics/EQL
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
Contributor
Author
|
Thanks @astefan! |
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 10, 2025
This was referenced Feb 10, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 10, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 10, 2025
This was referenced Feb 10, 2025
Collaborator
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 10, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JOIN command is in the grammar, but we have no implementation for it.
Since it's part of EQL spec, it makes sense to parse it correctly, but we'll make it return a validation exception with a meaningful error message.
Fixes: #122000