Skip to content

EQL: fix JOIN command validation (not supported) #122011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luigidellaquila merged 2 commits into from
Feb 10, 2025
Merged

EQL: fix JOIN command validation (not supported) #122011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
207c0f5
EQL: fix JOIN command validation (not supported)
luigidellaquila Feb 7, 2025
52ec14d
Update docs/changelog/122011.yaml
luigidellaquila Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/122011.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 122011
summary: Fix JOIN command validation (not supported)
area: EQL
type: bug
issues: []
3 changes: 3 additions & 0 deletions x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/analysis/Verifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ Collection<Failure> verify(LogicalPlan plan) {

// start bottom-up
plan.forEachUp(p -> {
if (p.getClass().equals(Join.class)) {
failures.add(fail(p, "JOIN command is not supported"));
}
if (p.analyzed()) {
return;
}
Expand Down
7 changes: 7 additions & 0 deletions x-pack/plugin/eql/src/test/java/org/elasticsearch/xpack/eql/analysis/VerifierTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,13 @@ public void testJoin() {
accept(idxr, "foo where serial_event_id == 0");
}

public void testJoinCommand() {
final IndexResolution idxr = loadIndexResolution("mapping-ip.json");

assertEquals("1:1: JOIN command is not supported", error(idxr, "join [any where true] [any where true]"));
assertEquals("1:1: JOIN command is not supported", error(idxr, "join [any where true] [any where true] | tail 3"));
}

public void testMultiField() {
final IndexResolution idxr = loadIndexResolution("mapping-multi-field.json");
accept(idxr, "foo where multi_field.raw == \"bar\"");
Expand Down