Remove another outdated assertion from SearchQueryThenFetchAsyncActionTests #122086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nTests Same reasoning as in 2b410c4, with the now weaker ordering guarantees from optimizations this assertion stopped being reliable.
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
javanna
approved these changes
Feb 13, 2025
original-brownbear
added
the
auto-backport
Contributor
Author
|
Thanks Luca! |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Member
|
@original-brownbear this still needs to be backported to 8.x, correct? Next the backport pending label can be removed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same reasoning as in 2b410c4, with the now weaker ordering guarantees from optimizations this assertion stopped being reliable.
closes #121503