Skip to content

Remove another outdated assertion from SearchQueryThenFetchAsyncActionTests #122086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
original-brownbear merged 3 commits into from
Feb 13, 2025
Merged

Remove another outdated assertion from SearchQueryThenFetchAsyncActionTests #122086

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59f6a78
Remove another outdated assertion from SearchQueryThenFetchAsyncActio…
original-brownbear Feb 7, 2025
bce0698
Merge branch 'main' into fix-121503
original-brownbear Feb 13, 2025
982b7fd
Merge branch 'main' into fix-121503
original-brownbear Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,9 +401,6 @@ tests:
- class: org.elasticsearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT
method: test {yaml=update/100_synthetic_source/keyword}
issue: https://github.com/elastic/elasticsearch/issues/121992
- class: org.elasticsearch.action.search.SearchQueryThenFetchAsyncActionTests
method: testBottomFieldSort
issue: https://github.com/elastic/elasticsearch/issues/121503
- class: org.elasticsearch.xpack.logsdb.LogsdbTestSuiteIT
method: test {yaml=/60_synthetic_source_recovery/synthetic recovery for synthetic source mode index}
issue: https://github.com/elastic/elasticsearch/issues/122026
Expand Down
8 changes: 2 additions & 6 deletions ...r/src/test/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncActionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,8 @@ protected void run() {
if (withScroll) {
assertFalse(canReturnNullResponse.get());
assertThat(numWithTopDocs.get(), equalTo(0));
} else {
if (withCollapse) {
assertThat(numWithTopDocs.get(), equalTo(0));
} else {
assertThat(numWithTopDocs.get(), greaterThanOrEqualTo(1));
}
} else if (withCollapse) {
assertThat(numWithTopDocs.get(), equalTo(0));
}
SearchPhaseController.ReducedQueryPhase phase = action.results.reduce();
assertThat(phase.numReducePhases(), greaterThanOrEqualTo(1));
Expand Down