Instrument methods on File that require write permission #122109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds instrumentation for File methods that require write permission. No server or plugins use these methods, so no policy changes were necessary. Note that since we are not planning to restrict temp file creation, the bootstrap self test on file writing was removed, which failed with these changes.
rjernst
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
reviewed
Feb 10, 2025
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
Looks good, but I'd test this with test-entitlements just to be sure any of these do not need other policy adjustments.
Also, can you add "relates to ES-10790" or similar to the description? (Its' the task for File).
Member
Author
|
@elasticmachine update branch |
ldematte
reviewed
Feb 11, 2025
| "org.elasticsearch.nativeaccess", | ||
| List.of( | ||
| new LoadNativeLibrariesEntitlement(), | ||
| new FilesEntitlement(Arrays.asList(dataDirs).stream().map(d -> new FileData(d.toString(), READ_WRITE)).toList()) |
Contributor
There was a problem hiding this comment.
Nit: Arrays.stream(dataDirs).map(d -> new FileData(d.toString(), READ_WRITE)).toList()
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 12, 2025
) This commit adds instrumentation for File methods that require write permission. No server or plugins use these methods, so no policy changes were necessary. Note that since we are not planning to restrict temp file creation, the bootstrap self test on file writing was removed, which failed with these changes.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 12, 2025
) This commit adds instrumentation for File methods that require write permission. No server or plugins use these methods, so no policy changes were necessary. Note that since we are not planning to restrict temp file creation, the bootstrap self test on file writing was removed, which failed with these changes.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 12, 2025
) This commit adds instrumentation for File methods that require write permission. No server or plugins use these methods, so no policy changes were necessary. Note that since we are not planning to restrict temp file creation, the bootstrap self test on file writing was removed, which failed with these changes.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…122389) This commit adds instrumentation for File methods that require write permission. No server or plugins use these methods, so no policy changes were necessary. Note that since we are not planning to restrict temp file creation, the bootstrap self test on file writing was removed, which failed with these changes.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…122387) This commit adds instrumentation for File methods that require write permission. No server or plugins use these methods, so no policy changes were necessary. Note that since we are not planning to restrict temp file creation, the bootstrap self test on file writing was removed, which failed with these changes.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…122388) This commit adds instrumentation for File methods that require write permission. No server or plugins use these methods, so no policy changes were necessary. Note that since we are not planning to restrict temp file creation, the bootstrap self test on file writing was removed, which failed with these changes.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 13, 2025
This commit adds instrumentation for File methods that require read permissions. see elastic#122109 for the write side
rjernst
added a commit
that referenced
this pull request
Feb 17, 2025
This commit adds instrumentation for File methods that require read permissions. see #122109 for the write side
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 17, 2025
) This commit adds instrumentation for File methods that require read permissions. see elastic#122109 for the write side
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 17, 2025
) This commit adds instrumentation for File methods that require read permissions. see elastic#122109 for the write side
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
mosche
pushed a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 18, 2025
) This commit adds instrumentation for File methods that require read permissions. see elastic#122109 for the write side (cherry picked from commit bf1cbb0) # Conflicts: # x-pack/plugin/security/src/main/plugin-metadata/entitlement-policy.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
…122862) This commit adds instrumentation for File methods that require read permissions. see #122109 for the write side (cherry picked from commit bf1cbb0) # Conflicts: # x-pack/plugin/security/src/main/plugin-metadata/entitlement-policy.yaml Co-authored-by: Ryan Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds instrumentation for File methods that require write permission. No server or plugins use these methods, so no policy changes were necessary. Note that since we are not planning to restrict temp file creation, the bootstrap self test on file writing was removed, which failed with these changes.