- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
Add entitlement checks for java.io stream classes #122406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change and code looks good, ofc let's wait for entitlements CI to see if/where we need policy files, but as soon as those are OK good for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but one question about ML
        
          
                x-pack/plugin/ml/src/main/plugin-metadata/entitlement-policy.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      aa75fea    to
    d922e1c      
    Compare
  
    | 
           This requires file permissions relative to the home directory by means of ldematte#2 / #122370  | 
    
| 
           Pinging @elastic/es-core-infra (Team:Core/Infra)  | 
    
| 
           the failing serverless check was fixed in #122797  | 
    
          💔 Backport failed
 You can use sqren/backport to manually backport by running   | 
    
(cherry picked from commit 8eb89cf) # Conflicts: # libs/entitlement/bridge/src/main/java/org/elasticsearch/entitlement/bridge/EntitlementChecker.java # libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
          💚 All backports created successfully
 Questions ?Please refer to the Backport tool documentation  | 
    
(cherry picked from commit 8eb89cf) # Conflicts: # libs/entitlement/bridge/src/main/java/org/elasticsearch/entitlement/bridge/EntitlementChecker.java # libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
Add entitlement checks for java.io stream classes
Relates to ES-10791