Skip to content

Conversation

@mosche
Copy link
Contributor

@mosche mosche commented Feb 12, 2025

Add entitlement checks for java.io stream classes

Relates to ES-10791

@mosche mosche added test-entitlements auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 v8.19.0 labels Feb 12, 2025
@mosche mosche added the :Core/Infra/Core Core issues without another label label Feb 12, 2025
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change and code looks good, ofc let's wait for entitlements CI to see if/where we need policy files, but as soon as those are OK good for me!

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but one question about ML

@mosche mosche force-pushed the entitlements/java.io-streams branch from aa75fea to d922e1c Compare February 14, 2025 08:53
@mosche
Copy link
Contributor Author

mosche commented Feb 14, 2025

This requires file permissions relative to the home directory by means of ldematte#2 / #122370

@mosche mosche marked this pull request as ready for review February 18, 2025 08:07
@mosche mosche requested a review from a team as a code owner February 18, 2025 08:07
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 18, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mosche mosche merged commit 8eb89cf into elastic:main Feb 18, 2025
21 of 22 checks passed
@mosche mosche deleted the entitlements/java.io-streams branch February 18, 2025 13:12
@mosche
Copy link
Contributor Author

mosche commented Feb 18, 2025

the failing serverless check was fixed in #122797

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0
8.18 Commit could not be cherrypicked due to conflicts
8.x

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122406

mosche added a commit to mosche/elasticsearch that referenced this pull request Feb 18, 2025
(cherry picked from commit 8eb89cf)

# Conflicts:
#	libs/entitlement/bridge/src/main/java/org/elasticsearch/entitlement/bridge/EntitlementChecker.java
#	libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
@mosche
Copy link
Contributor Author

mosche commented Feb 18, 2025

💚 All backports created successfully

Status Branch Result
8.18

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Feb 18, 2025
(cherry picked from commit 8eb89cf)

# Conflicts:
#	libs/entitlement/bridge/src/main/java/org/elasticsearch/entitlement/bridge/EntitlementChecker.java
#	libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants