Fix synthetic source bug that would mishandle nested dense_vector fields #122425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
auto-backport
elasticsearchmachine
added
Team:StorageEngine
Team:Search Relevance
|
Hi @benwtrent, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
benwtrent
added
the
auto-merge-without-approval
|
Hi @benwtrent, I've updated the changelog YAML for you. |
benwtrent
deleted the
bugfix/fix-nested-dense-vector-synthetic-behavior
branch
💔 Backport failed
You can use sqren/backport to manually backport by running |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 12, 2025
…lds (elastic#122425) When utilizing synthetic source with nested fields, we attempt to rebuild the child values in addition to all the parent values. While this generally works well, its potential that certain values might be missing from various child docs. Consequently, we will attempt to iterate the vector values strangely, resulting in seemingly missing values or potentially exceptions indicating EOFs. closes: elastic#122383
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 12, 2025
…lds (elastic#122425) When utilizing synthetic source with nested fields, we attempt to rebuild the child values in addition to all the parent values. While this generally works well, its potential that certain values might be missing from various child docs. Consequently, we will attempt to iterate the vector values strangely, resulting in seemingly missing values or potentially exceptions indicating EOFs. closes: elastic#122383 (cherry picked from commit f5c901e)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 12, 2025
…lds (elastic#122425) When utilizing synthetic source with nested fields, we attempt to rebuild the child values in addition to all the parent values. While this generally works well, its potential that certain values might be missing from various child docs. Consequently, we will attempt to iterate the vector values strangely, resulting in seemingly missing values or potentially exceptions indicating EOFs. closes: elastic#122383 (cherry picked from commit f5c901e)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…lds (#122425) (#122434) When utilizing synthetic source with nested fields, we attempt to rebuild the child values in addition to all the parent values. While this generally works well, its potential that certain values might be missing from various child docs. Consequently, we will attempt to iterate the vector values strangely, resulting in seemingly missing values or potentially exceptions indicating EOFs. closes: #122383
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…lds (#122425) (#122437) When utilizing synthetic source with nested fields, we attempt to rebuild the child values in addition to all the parent values. While this generally works well, its potential that certain values might be missing from various child docs. Consequently, we will attempt to iterate the vector values strangely, resulting in seemingly missing values or potentially exceptions indicating EOFs. closes: #122383 (cherry picked from commit f5c901e)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…lds (#122425) (#122436) When utilizing synthetic source with nested fields, we attempt to rebuild the child values in addition to all the parent values. While this generally works well, its potential that certain values might be missing from various child docs. Consequently, we will attempt to iterate the vector values strangely, resulting in seemingly missing values or potentially exceptions indicating EOFs. closes: #122383 (cherry picked from commit f5c901e)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 13, 2025
…or fields (#122425) (#122435) * Fix synthetic source bug that would mishandle nested dense_vector fields (#122425) When utilizing synthetic source with nested fields, we attempt to rebuild the child values in addition to all the parent values. While this generally works well, its potential that certain values might be missing from various child docs. Consequently, we will attempt to iterate the vector values strangely, resulting in seemingly missing values or potentially exceptions indicating EOFs. closes: #122383 (cherry picked from commit f5c901e) * fixing backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When utilizing synthetic source with nested fields, we attempt to rebuild the child values in addition to all the parent values.
While this generally works well, its potential that certain values might be missing from various child docs. Consequently, we will attempt to iterate the vector values strangely, resulting in seemingly missing values or potentially exceptions indicating EOFs.
closes: #122383