Add support for setting based file entitlements #122656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Security Manager we have SecuredConfigFileSettingAccessPermission. This commit adds an entitlement equivalent. With each entry in files entitlement, a `path_setting` can now be used. The value may be an explicit setting, or a setting glob with a single `*`. relates ES-10844
rjernst
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
commented
Feb 15, 2025
| } | ||
| } | ||
|
|
||
| final class AbsolutePathFileData implements FileData { |
Member
Author
There was a problem hiding this comment.
Note: I'll align these implementations completely once #122658 is merged.
ldematte
approved these changes
Feb 17, 2025
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
One optional observation but LGTM
| Path configDir, | ||
| Path[] dataDirs, | ||
| Path tempDir, | ||
| Function<String, String> settingResolver, |
Contributor
There was a problem hiding this comment.
This is why I think and interface is better than a record here; a record with 2 Function is just and interface in disguise. OK to keep *Dir() as simple getters though.
Not blocking.
Contributor
There was a problem hiding this comment.
I'm still in favor of the record here as there is only a single implementation. The resolvers are just necessary due to Settings not being available in the entitlements lib
Member
Author
There was a problem hiding this comment.
I agree with Moritz, I prefer a record because it is "things" we are passing in. Creating an interface would require creating an implementation, but the record provides that.
This was referenced Feb 17, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 18, 2025
With Security Manager we have SecuredConfigFileSettingAccessPermission. This commit adds an entitlement equivalent. With each entry in files entitlement, a `path_setting` can now be used. The value may be an explicit setting, or a setting glob with a single `*`. relates ES-10844
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 18, 2025
With Security Manager we have SecuredConfigFileSettingAccessPermission. This commit adds an entitlement equivalent. With each entry in files entitlement, a `path_setting` can now be used. The value may be an explicit setting, or a setting glob with a single `*`. relates ES-10844
Collaborator
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 18, 2025
With Security Manager we have SecuredConfigFileSettingAccessPermission. This commit adds an entitlement equivalent. With each entry in files entitlement, a `path_setting` can now be used. The value may be an explicit setting, or a setting glob with a single `*`. relates ES-10844
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
With Security Manager we have SecuredConfigFileSettingAccessPermission. This commit adds an entitlement equivalent. With each entry in files entitlement, a `path_setting` can now be used. The value may be an explicit setting, or a setting glob with a single `*`. relates ES-10844
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
With Security Manager we have SecuredConfigFileSettingAccessPermission. This commit adds an entitlement equivalent. With each entry in files entitlement, a `path_setting` can now be used. The value may be an explicit setting, or a setting glob with a single `*`. relates ES-10844
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
With Security Manager we have SecuredConfigFileSettingAccessPermission. This commit adds an entitlement equivalent. With each entry in files entitlement, a `path_setting` can now be used. The value may be an explicit setting, or a setting glob with a single `*`. relates ES-10844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Security Manager we have SecuredConfigFileSettingAccessPermission. This commit adds an entitlement equivalent. With each entry in files entitlement, a
path_settingcan now be used. The value may be an explicit setting, or a setting glob with a single*.relates ES-10844