GCS blob store: add OperationPurpose/Operation stats counters #122991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktindall
reviewed
Feb 21, 2025
...-gcs/src/main/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageOperationsStats.java
Outdated
Show resolved
Hide resolved
nicktindall
reviewed
Feb 21, 2025
...-gcs/src/main/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageOperationsStats.java
Show resolved
Hide resolved
nicktindall
approved these changes
Mar 5, 2025
...sitory-gcs/src/main/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageBlobStore.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageHttpStatsCollector.java
Outdated
Show resolved
Hide resolved
mhl-b
changed the title
mhl-b
changed the title
mhl-b
changed the title
mhl-b
changed the title
mhl-b
added
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Collaborator
|
Hi @mhl-b, I've created a changelog YAML for you. |
Contributor
Author
|
@nicktindall , please take a look at the last commit a5549e4 I updated CAS test, added assertion for ignored request, and minor refactor in the test code. |
nicktindall
reviewed
Mar 6, 2025
.../test/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageBlobContainerStatsTests.java
Outdated
Show resolved
Hide resolved
nicktindall
reviewed
Mar 6, 2025
| this.statsTracker = statsTracker; | ||
| var respCode = response.getStatusCode(); | ||
| // Some of the intermediate and error codes are still counted as "good" requests | ||
| if (((respCode >= 200 && respCode < 300) || respCode == 308 || respCode == 404) == false) { |
Contributor
There was a problem hiding this comment.
Nit: for the first condition we could use org.elasticsearch.rest.RestStatus#isSuccessful, that logic was repeated in lots of places. Unless you think that obscures it.
Contributor
Author
There was a problem hiding this comment.
I think it's more readable in this form since multiple codes are handled. I'm more concerned about codes I dont handle here, but we would like to.
nicktindall
reviewed
Mar 6, 2025
| this.tracker = new ServerlessTracker(bucketName); | ||
| } else { | ||
| this.tracker = new StatefulTracker(); | ||
| } |
elasticsearchmachine
added
the
serverless-linked
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add counters for operations and requests for each combination of OperationPurpose and Operation for GCS blob store. Align with other BlobStore implementations (AWS and Azure).
Refactored
GoogleCloudStorageHttpStatsCollector. Removed indirection oftrackersandtrackerFactories.ES-10213
ES-10863