ESQL: Add known issue for slow VALUES #123222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are so so so slow that this is effectively a bad bug.
|
Documentation preview: |
|
Pinging @elastic/es-docs (Team:Docs) |
elasticsearchmachine
added
v8.16.5
Team:Docs
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
leemthompo
reviewed
Feb 24, 2025
|
|
||
| ES|QL:: | ||
|
|
||
| * `VALUES` aggregate function can run for a long, long time when collecting many, many groups. This can consume a thread for days at the worst case. Fixed by {es-pull}#123073[#123073] and available in 8.16.5, 8.17.3, 8.18.0, and all releases after that. |
There was a problem hiding this comment.
@nik9000 any way we can quantify "many" here?
There was a problem hiding this comment.
It's n^2 so it's a sliding scale. But millions of buckets can run for days. Hundreds of thousands of buckets can run for many minutes. I'll push something with that in it.
|
@leemthompo, could you have another look? |
leemthompo
reviewed
Feb 24, 2025
leemthompo
approved these changes
Feb 24, 2025
Co-authored-by: Liam Thompson <[email protected]>
|
I've applied the copy editing and set it to auto-merge. I'll drag it into 8.17 as well and auto-merge-without-review that one. |
|
8.17: #123288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are so so so slow that this is effectively a bad bug.