ESQL: Reduce iteration complexity for plan traversal #123427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costin
added
>bug
:Analytics/ES|QL
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
Hi @costin, I've created a changelog YAML for you. |
luigidellaquila
approved these changes
Feb 26, 2025
bpintea
approved these changes
Feb 26, 2025
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Feb 26, 2025
(cherry picked from commit e4604a4)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 26, 2025
costin
added a commit
that referenced
this pull request
Feb 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the iteration to calling a full tree navigation per node (forEach already performs a full tree traversal) so it's back to O(N) instead of O(N^3) (forEach, call forEach per node, which calls forEach per child).