Skip to content

Conversation

@leemthompo
Copy link
Contributor

Reverts #123570 because docs eng has fixed the issue cc @Mpdreamz

@elasticsearchmachine elasticsearchmachine added v9.1.0 needs:triage Requires assignment of a team area label labels Feb 27, 2025
@leemthompo leemthompo added :Analytics/Aggregations Aggregations :Analytics/EQL EQL querying and removed needs:triage Requires assignment of a team area label labels Feb 27, 2025
@leemthompo leemthompo requested a review from a team February 27, 2025 10:14
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@leemthompo leemthompo added Team:Docs Meta label for docs team and removed :Analytics/Aggregations Aggregations :Analytics/EQL EQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Feb 27, 2025
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Docs Meta label for docs team labels Feb 27, 2025
@leemthompo leemthompo added the >docs General docs changes label Feb 27, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Feb 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Feb 27, 2025
@Mpdreamz
Copy link
Member

For reference: this was happening because we run on the merge commit so the git diff on out of date PR's could still be flagged as having docs changes.

The docs-builder CLI itself is now able to detect this situation and hint through GitHub action outputs to skip itself and subsequent steps.

An example where this was failing initially is:

https://github.com/elastic/elasticsearch/actions/runs/13554852408/job/37910360083

and now succeeding:

https://github.com/elastic/elasticsearch/actions/runs/13554852408

Copy link
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@leemthompo leemthompo merged commit 731a412 into main Feb 27, 2025
5 of 17 checks passed
@leemthompo leemthompo deleted the revert-123570-revert-123506-add-new-docs-ci branch February 27, 2025 10:23
package org.elasticsearch;

import org.elasticsearch.core.Assertions;
import org.elasticsearch.core.FixForMultiProject;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes Team:Docs Meta label for docs team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants