Avoiding a race condition where pending indices count is 0 at start of data stream reindex #123765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
added
auto-backport
elasticsearchmachine
added
the
Team:Data Management
parkertimmins
approved these changes
Feb 28, 2025
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Feb 28, 2025
…f data stream reindex (elastic#123765)
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Feb 28, 2025
…f data stream reindex (elastic#123765)
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Feb 28, 2025
…f data stream reindex (elastic#123765)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a very short time, the pending indices count is 0. Since ReindexDataStreamEnrichedStatus uses the pending count to compute the number of successes shown in the upgrade assistant, the upgrade assistant very briefly shows 100% success when a task starts. This fixes that by initializing pending to totalIndicesToBeUpgraded rather than to 0.
I have also tacked on two things that have been bugging me: a misspelled word in a comment, and a difficult-to-read task description.