Skip to content

Avoiding a race condition where pending indices count is 0 at start of data stream reindex #123765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Avoiding a race condition where pending indices count is 0 at start of data stream reindex #123765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
826115d
Avoiding a race condition where pending indices count is 0 at start o…
masseyke Feb 28, 2025
e2e170f
fixed a typo in a comment
masseyke Feb 28, 2025
9980b04
Improving the reindex task descritpion
masseyke Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/org/elasticsearch/xpack/migrate/action/GetMigrationReindexStatusTransportAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ private void reportStatus(
}

/*
* This method feches doc counts for all indices in inProgressIndices (and the indices they are being reindexed into). After
* This method fetches doc counts for all indices in inProgressIndices (and the indices they are being reindexed into). After
* successfully fetching those, reportStatus is called.
*/
private void fetchInProgressStatsAndReportStatus(
Expand Down
2 changes: 1 addition & 1 deletion ...in/java/org/elasticsearch/xpack/migrate/task/ReindexDataStreamPersistentTaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ protected ReindexDataStreamTask createTask(
id,
type,
action,
"id=" + taskInProgress.getId(),
"Reindexing data stream " + taskInProgress.getParams().getSourceDataStream(),
parentTaskId,
headers
);
Expand Down
1 change: 1 addition & 0 deletions ...gin/migrate/src/main/java/org/elasticsearch/xpack/migrate/task/ReindexDataStreamTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ public ReindexDataStreamTask(
this.persistentTaskStartTime = persistentTaskStartTime;
this.initialTotalIndices = initialTotalIndices;
this.initialTotalIndicesToBeUpgraded = initialTotalIndicesToBeUpgraded;
this.pending.set(initialTotalIndicesToBeUpgraded);
this.completeTask = new RunOnce(() -> {
if (exception == null) {
markAsCompleted();
Expand Down