Align TransportVersion#bestKnownVersion with 8.x
#123801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In backporting elastic#123397 to 8.x we discovered that we needed to generalize `TransportVersion#bestKnownVersion` slightly to handle older versions. This commit forward-ports this change to keep the branches aligned.
DaveCTurner
added
>non-issue
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Mar 4, 2025
DaveCTurner
deleted the
2025/03/01/TransportVersion-bestKnownVersion-isKnown
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 4, 2025
In backporting elastic#123397 to 8.x we discovered that we needed to generalize `TransportVersion#bestKnownVersion` slightly to handle older versions. This commit forward-ports this change to keep the branches aligned.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
In backporting #123397 to 8.x we discovered that we needed to generalize `TransportVersion#bestKnownVersion` slightly to handle older versions. This commit forward-ports this change to keep the branches aligned.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
In backporting elastic#123397 to 8.x we discovered that we needed to generalize `TransportVersion#bestKnownVersion` slightly to handle older versions. This commit forward-ports this change to keep the branches aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In backporting #123397 to 8.x we discovered that we needed to generalize
TransportVersion#bestKnownVersionslightly to handle older versions.This commit forward-ports this change to keep the branches aligned.