- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
[9.0] Remove duplicate paths (including exclusive) in FileAccessTree (#123776 and #124023) #123924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Co-authored-by: Lorenzo Dematté <[email protected]> Co-authored-by: Patrick Doyle <[email protected]>
| 
           Pinging @elastic/es-core-infra (Team:Core/Infra)  | 
    
| 
           The plan is to hold off merging this until   | 
    
* Remove duplicate exclusive paths * Normalize paths in tests to support Windows * Remove withMode
| 
           I've cherry-picked #124023  | 
    
| 
           The CI passed but the GitHub status didn't get updated. I'll merge.  | 
    
    
  prdoyle 
      added a commit
        to prdoyle/elasticsearch
      that referenced
      this pull request
    
      Mar 7, 2025 
    
    
      
  
    
      
    
  
…lastic#123776 and elastic#124023) (elastic#123924) * remove duplicate paths in FileAccessTree (elastic#123776) Co-authored-by: Lorenzo Dematté <[email protected]> Co-authored-by: Patrick Doyle <[email protected]> * Remove duplicate exclusive paths (elastic#124023) * Remove duplicate exclusive paths * Normalize paths in tests to support Windows * Remove withMode --------- Co-authored-by: Jack Conradson <[email protected]> Co-authored-by: Lorenzo Dematté <[email protected]>
    
  prdoyle 
      added a commit
        to prdoyle/elasticsearch
      that referenced
      this pull request
    
      Mar 7, 2025 
    
    
      
  
    
      
    
  
…lastic#123776 and elastic#124023) (elastic#123924) * remove duplicate paths in FileAccessTree (elastic#123776) Co-authored-by: Lorenzo Dematté <[email protected]> Co-authored-by: Patrick Doyle <[email protected]> * Remove duplicate exclusive paths (elastic#124023) * Remove duplicate exclusive paths * Normalize paths in tests to support Windows * Remove withMode --------- Co-authored-by: Jack Conradson <[email protected]> Co-authored-by: Lorenzo Dematté <[email protected]>
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Mar 8, 2025 
    
    
      
  
    
      
    
  
…123776 and #124023) (#123924) (#124331) * remove duplicate paths in FileAccessTree (#123776) * Remove duplicate exclusive paths (#124023) * Remove duplicate exclusive paths * Normalize paths in tests to support Windows * Remove withMode --------- Co-authored-by: Jack Conradson <[email protected]> Co-authored-by: Lorenzo Dematté <[email protected]>
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Mar 9, 2025 
    
    
      
  
    
      
    
  
…123776 and #124023) (#123924) (#124332) * remove duplicate paths in FileAccessTree (#123776) * Remove duplicate exclusive paths (#124023) * Remove duplicate exclusive paths * Normalize paths in tests to support Windows * Remove withMode --------- Co-authored-by: Jack Conradson <[email protected]> Co-authored-by: Lorenzo Dematté <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    auto-backport
  Automatically create backport pull requests when merged 
  
    auto-merge-without-approval
  Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) 
  
    :Core/Infra/Entitlements
  Entitlements infrastructure 
  
    >non-issue
  
    Team:Core/Infra
  Meta label for core/infra team 
  
    test-windows
  Trigger CI checks on Windows 
  
    v8.18.1
  
    v8.19.0
  
    v9.0.1
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Backport of: #123776 and #124023