Fix IronBank hardening_manifest CI test #124579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286
elasticsearchmachine
added
needs:triage
breskeby
requested changes
Mar 11, 2025
Contributor
breskeby
left a comment
breskeby
left a comment
There was a problem hiding this comment.
in the email the German umlaut is not replaced properly. actually its ö -> oe
| email: "[email protected]" | ||
| username: "mark-vieira" | ||
| - name: "Rene Gröschke" | ||
| - name: "Rene Groschke" |
Contributor
There was a problem hiding this comment.
Can we make it Rene Groeschke then? :)
distribution/docker/src/docker/iron_bank/hardening_manifest.yaml
Outdated
Show resolved
Hide resolved
breskeby
added
>non-issue
Team:Delivery
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
elasticsearchmachine
removed
the
needs:triage
breskeby
added
the
auto-merge-without-approval
breskeby
approved these changes
Mar 11, 2025
Contributor
|
no worries. took care of it. I take it from here |
Member
Author
|
@breskeby do we need to also add some |
breskeby
added
backport
auto-backport
Contributor
yes. I added this and the back port label |
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597)
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597)
Contributor
|
I created back ports for all active branches to keep those files in sync. should be no harm |
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597)
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597)
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597) # Conflicts: # distribution/docker/src/docker/iron_bank/hardening_manifest.yaml
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597) # Conflicts: # distribution/docker/src/docker/iron_bank/hardening_manifest.yaml
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597) Co-authored-by: Julien Mailleret <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597) # Conflicts: # distribution/docker/src/docker/iron_bank/hardening_manifest.yaml Co-authored-by: Julien Mailleret <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597) Co-authored-by: Julien Mailleret <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that. (cherry picked from commit e5cf597) # Conflicts: # distribution/docker/src/docker/iron_bank/hardening_manifest.yaml Co-authored-by: Julien Mailleret <[email protected]>
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
breskeby
added a commit
that referenced
this pull request
Mar 12, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match `'^(?!\\s*$)[ -~|]*$'` regex: ``` | hardening_manifest | ERROR | Hardening Manifest failed jsonschema validation | hardening_manifest | ERROR | Verify Hardening Manifest content | hardening_manifest | ERROR | 'Rene Gröschke' does not match '^(?!\\s*$)[ -~|]*$' ``` https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286 cc @breskeby <!-- Thank you for your interest in and contributing to Elasticsearch! There are a few simple things to check before submitting your pull request that can help with the review process. You should delete these items from your submission, but they are here to help bring them to your attention. --> - Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? - Have you followed the [contributor guidelines](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md)? - If submitting code, have you built your formula locally prior to submission with `gradle check`? - If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. - If submitting code, have you checked that your submission is for an [OS and architecture that we support](https://www.elastic.co/support/matrix#show_os)? - If you are submitting this code for a class then read our [policy](https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-as-part-of-a-class) for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the IronBank hardening_manifest CI test that expect the hardening_manifest.yaml values to match
'^(?!\\s*$)[ -~|]*$'regex:https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch9/-/jobs/43219286
cc @breskeby
gradle check?