Follow-up: Remove Logger Calls in Tests #124650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
mridula-s109
added
:SearchOrg/Relevance
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
kderusso
approved these changes
Mar 12, 2025
Member
kderusso
left a comment
kderusso
left a comment
There was a problem hiding this comment.
LGTM. Can you please do a pass through the original PR and see if any other regressions were introduced through that merge? Thanks!
Contributor
Author
Thanks Kathleen. have checked and there are no regressions. |
Collaborator
|
Hi @mridula-s109, I've created a changelog YAML for you. |
Mikep86
approved these changes
Mar 12, 2025
Contributor
|
We don't need a changelog entry for this. I changed the label to non-issue to remove it. |
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
mridula-s109
added a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 44a3ac4) # Conflicts: # x-pack/plugin/ent-search/src/test/java/org/elasticsearch/xpack/application/rules/QueryRuleTests.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mridula-s109
added a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 44a3ac4)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
mridula-s109
added a commit
that referenced
this pull request
Mar 13, 2025
… Criteria (#122823) | Removed logger and also fixed the nitpick comments (#124650) (#124758) * Prevent Query Rule Creation with Invalid Numeric Match Criteria (#122823) * SEARCH-802 - bug fixed - Query rules allows for creation of rules with invalid match criteria * [CI] Auto commit changes from spotless * Worked on the comments given in the PR * [CI] Auto commit changes from spotless * Fixed Integration tests * [CI] Auto commit changes from spotless * Made changes from the PR * Update docs/changelog/122823.yaml * [CI] Auto commit changes from spotless * Fixed the duplicate code issue in queryRuleTests * Refactored code to clean it up based on PR comments * [CI] Auto commit changes from spotless * Logger statements were removed * Cleaned up the QueryRule tests * [CI] Auto commit changes from spotless * Update x-pack/plugin/ent-search/src/test/java/org/elasticsearch/xpack/application/EnterpriseSearchModuleTestUtils.java Co-authored-by: Mike Pellegrini <[email protected]> * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Kathleen DeRusso <[email protected]> Co-authored-by: Mike Pellegrini <[email protected]> (cherry picked from commit f6538e8) # Conflicts: # x-pack/plugin/ent-search/src/main/java/org/elasticsearch/xpack/application/EnterpriseSearchFeatures.java * Removed logger and also fixed the nitpick comments (#124650) (cherry picked from commit 44a3ac4) * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a follow-up to PR #122823, which introduced query rules. In this PR, we remove unnecessary logger calls from test files to keep test outputs clean and maintainable.
Changes:
✅ Removed all logger.info(), logger.debug(), and other logging calls from test files.
✅ Verified that all tests pass successfully after the cleanup.