Skip to content

Follow-up: Remove Logger Calls in Tests #124650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Follow-up: Remove Logger Calls in Tests #124650

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85c932a
Removed logger and also fixed the nitpick comments
mridula-s109 Mar 12, 2025
fdd64dc
Merge branch 'main' into remove-logger-calls-in-tests
mridula-s109 Mar 12, 2025
f67792d
Update docs/changelog/124650.yaml
mridula-s109 Mar 12, 2025
e6797fb
Delete docs/changelog/124650.yaml
mridula-s109 Mar 12, 2025
da35111
Merge branch 'main' into remove-logger-calls-in-tests
mridula-s109 Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/124650.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 124650
summary: "Follow-up: Remove Logger Calls in Tests"
area: Relevance
type: enhancement
issues: []
9 changes: 2 additions & 7 deletions ...in/ent-search/src/test/java/org/elasticsearch/xpack/application/rules/QueryRuleTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,7 @@ public void testNumericValidationWithEmptyValues() throws IOException {
IllegalArgumentException.class,
() -> QueryRule.fromXContentBytes(new BytesArray(content), XContentType.JSON)
);
logger.info("Actual error message: " + e.getMessage());
assertTrue(e.getMessage().contains("failed to parse field [criteria]"));
assertThat(e.getMessage(), containsString("failed to parse field [criteria]"));
}

public void testToXContent() throws IOException {
Expand Down Expand Up @@ -158,11 +157,7 @@ public void testToXContentEmptyCriteria() throws IOException {
IllegalArgumentException.class,
() -> QueryRule.fromXContentBytes(new BytesArray(content), XContentType.JSON)
);
logger.info("Actual error message for empty criteria: " + e.getMessage());
assertTrue(
"Error message [" + e.getMessage() + "] should contain 'Failed to build [query_rule]'",
e.getMessage().contains("Failed to build [query_rule]")
);
assertThat(e.getMessage(), containsString("Failed to build [query_rule]"));
}

public void testToXContentValidPinnedRulesWithIds() throws IOException {
Expand Down