Skip to content

ESQL: Don't run INLINESTATS optimizer tests in release builds #124889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

ESQL: Don't run INLINESTATS optimizer tests in release builds #124889

merged 2 commits into from
Mar 14, 2025
+3 −6

Conversation

@alex-spies
Copy link
Contributor

@alex-spies alex-spies commented Mar 14, 2025

Fix #124838
Fix #124839

@alex-spies alex-spies added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.1 v9.1.0 test-release Trigger CI checks against release build labels Mar 14, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 14, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 14, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@alex-spies alex-spies added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 14, 2025
costin
costin approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-spies
Copy link
Contributor Author

alex-spies commented Mar 14, 2025

There's a bunch of unrelated CI failures. I'm going to ignore them this time to avoid blocking this simple test skip. (The tests affected by this PR didn't fail.)

@alex-spies alex-spies merged commit 3d6eb26 into elastic:main Mar 14, 2025
15 of 20 checks passed
@alex-spies alex-spies deleted the fix-propagateinlineevals-tests branch March 14, 2025 17:45
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 14, 2025

💔 Backport failed

Status Branch Result
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 124889

@nik9000
Copy link
Member

nik9000 commented Mar 14, 2025

✔️

@nik9000
Copy link
Member

nik9000 commented Mar 14, 2025

LGTM

@nik9000
Copy link
Member

nik9000 commented Mar 14, 2025

:shipit:

@nik9000
Copy link
Member

nik9000 commented Mar 14, 2025

pirate-pirate-ship

@alex-spies alex-spies mentioned this pull request Mar 17, 2025
Merged
@alex-spies
Copy link
Contributor Author

alex-spies commented Mar 17, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Questions ?

Please refer to the Backport tool documentation

alex-spies added a commit to alex-spies/elasticsearch that referenced this pull request Mar 17, 2025
@alex-spies
ESQL: Don't run INLINESTATS optimizer tests in release builds (elasti…
8c1b49b 
…c#124889)

(cherry picked from commit 3d6eb26)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Mar 17, 2025
@alex-spies
ESQL: Don't run INLINESTATS optimizer tests in release builds (#124889)…
296c7f5 
… (#125004)

(cherry picked from commit 3d6eb26)

# Conflicts:
#	muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costin costin costin approved these changes

@nik9000 nik9000 nik9000 approved these changes

@idegtiarenko idegtiarenko idegtiarenko approved these changes

@bpintea bpintea bpintea approved these changes

@ivancea ivancea ivancea approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

7 participants

@alex-spies @elasticsearchmachine @nik9000 @costin @idegtiarenko @bpintea @ivancea