Skip to content

Fix invalid setting value in ShardBulkInferenceActionFilter tests #125006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Fix invalid setting value in ShardBulkInferenceActionFilter tests #125006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45c12e9
Fix invalid setting value in tests
jimczi Mar 17, 2025
ea91df1
Merge branch 'main' into shard_bulk_size_set
jimczi Mar 17, 2025
d30f5d1
unmute tests
jimczi Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,6 @@ tests:
- class: org.elasticsearch.xpack.ilm.DataStreamAndIndexLifecycleMixingTests
method: testIndexTemplateSwapsILMForDataStreamLifecycle
issue: https://github.com/elastic/elasticsearch/issues/124886
- class: org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterTests
method: testExplicitNull {p0=false}
issue: https://github.com/elastic/elasticsearch/issues/124891
- class: org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterTests
method: testExplicitNull {p0=true}
issue: https://github.com/elastic/elasticsearch/issues/124892
- class: org.elasticsearch.packaging.test.BootstrapCheckTests
method: test20RunWithBootstrapChecks
issue: https://github.com/elastic/elasticsearch/issues/124940
Expand Down
2 changes: 1 addition & 1 deletion ...ava/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public void setup() throws Exception {

@Override
protected Settings nodeSettings(int nodeOrdinal, Settings otherSettings) {
long batchSizeInBytes = randomLongBetween(0, ByteSizeValue.ofKb(1).getBytes());
long batchSizeInBytes = randomLongBetween(1, ByteSizeValue.ofKb(1).getBytes());
return Settings.builder()
.put(otherSettings)
.put(LicenseSettings.SELF_GENERATED_LICENSE_TYPE.getKey(), "trial")
Expand Down
2 changes: 1 addition & 1 deletion .../org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ private static ClusterService createClusterService(boolean useLegacyFormat) {
ClusterState clusterState = ClusterState.builder(new ClusterName("test")).metadata(metadata).build();
ClusterService clusterService = mock(ClusterService.class);
when(clusterService.state()).thenReturn(clusterState);
long batchSizeInBytes = randomLongBetween(0, ByteSizeValue.ofKb(1).getBytes());
long batchSizeInBytes = randomLongBetween(1, ByteSizeValue.ofKb(1).getBytes());
Settings settings = Settings.builder().put(INDICES_INFERENCE_BATCH_SIZE.getKey(), ByteSizeValue.ofBytes(batchSizeInBytes)).build();
when(clusterService.getSettings()).thenReturn(settings);
when(clusterService.getClusterSettings()).thenReturn(new ClusterSettings(settings, Set.of(INDICES_INFERENCE_BATCH_SIZE)));
Expand Down