Skip to content

Fix invalid setting value in ShardBulkInferenceActionFilter tests #125006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

Fix invalid setting value in ShardBulkInferenceActionFilter tests #125006

merged 3 commits into from
Mar 17, 2025

Conversation

@jimczi
Copy link
Contributor

@jimczi jimczi commented Mar 17, 2025 •
edited
Loading

0 is not a valid value.

Closes #124985
Closes #124986
Closes #124955
Closes #124954

@jimczi jimczi added >test Issues or PRs that are addressing/adding tests :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.19.0 v9.1.0 labels Mar 17, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 17, 2025

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 17, 2025

Pinging @elastic/search-relevance (Team:Search - Relevance)

Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kderusso
kderusso approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimczi jimczi added the auto-backport Automatically create backport pull requests when merged label Mar 17, 2025
@jimczi jimczi merged commit 665e890 into elastic:main Mar 17, 2025
17 checks passed
@jimczi jimczi deleted the shard_bulk_size_set branch March 17, 2025 12:31
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 17, 2025

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125006

@jimczi jimczi mentioned this pull request Mar 17, 2025
Merged
This was referenced Mar 17, 2025
Closed
Closed
elasticsearchmachine pushed a commit that referenced this pull request Mar 17, 2025
@jimczi @elasticmachine
Fix invalid setting value in ShardBulkInferenceActionFilter tests (#1…
a95c3ea 
…25006) (#125022)

0 is not a valid value.

Closes #124985
Closes #124986
Closes #124955
Closes #124954

Co-authored-by: Elastic Machine <[email protected]>
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@jimczi @omricohenn
Fix invalid setting value in ShardBulkInferenceActionFilter tests (el…
de15de4 
…astic#125006)

0 is not a valid value.

Closes elastic#124985
Closes elastic#124986
Closes elastic#124955
Closes elastic#124954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kderusso kderusso kderusso approved these changes

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending :SearchOrg/Relevance Label for the Search (solution/org) Relevance team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

4 participants

@jimczi @elasticsearchmachine @kderusso @Samiul-TheSoccerFan