Add a generic method for reading shard field stats from an Engine #125055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
added
the
:Distributed Indexing/Engine
arteam
changed the title
elasticsearchmachine
added
the
serverless-linked
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
fcofdez
reviewed
Mar 24, 2025
| } | ||
| } | ||
|
|
||
| protected ShardFieldStats shardFieldStats(List<LeafReaderContext> leaves) { |
There was a problem hiding this comment.
I think that we should make this method static.
There was a problem hiding this comment.
Good point! I've changed it to be static cb2b70b
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…astic#125055) Support reading shard field stats outside of `IndexShard` in read-only engines. See ES-11062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support reading shard field stats outside of
IndexShardin read-only engines.See ES-11062