Add rule retriever yaml test with empty indices #125161
Conversation
kderusso
added
>test
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
| private static final NodeFeature TEST_RERANKING_SERVICE_PARSE_TEXT_AS_SCORE = new NodeFeature( | ||
| "test_reranking_service.parse_text_as_score" | ||
| ); | ||
| private static final NodeFeature TEST_RULE_RETRIEVER_WITH_EMPTY_INDEX = new NodeFeature("test_rule_retriever.with_empty_index"); |
There was a problem hiding this comment.
I couldn't find the feature this was fixed in, so I added a new test feature.
| private static final NodeFeature TEST_RERANKING_SERVICE_PARSE_TEXT_AS_SCORE = new NodeFeature( | ||
| "test_reranking_service.parse_text_as_score" | ||
| ); | ||
| private static final NodeFeature TEST_RULE_RETRIEVER_WITH_EMPTY_INDEX = new NodeFeature("test_rule_retriever.with_empty_index"); |
There was a problem hiding this comment.
Nit: this isn't a great description of the issue as the index isn't empty. Is there a more accurate feature name we can use?
There was a problem hiding this comment.
I mean, technically it's empty in the result set, but I'll make a more verbose name 😜
There was a problem hiding this comment.
"Empty result set" is more descriptive, thank you :)
There was a problem hiding this comment.
Also I didn't backport it because I wasn't sure of the fix. It's just an aadditional test though so I think it's OK.
* Add rule retriever yaml test with empty indices * Add more specificity to NodeFeature name
* Add rule retriever yaml test with empty indices * Add more specificity to NodeFeature name
5 participants
See: SEARCH-910