Skip to content

Set the level for zstd best speed to 1 #125375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025
Merged

Set the level for zstd best speed to 1 #125375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c4fbe2
Set the level for zstd best speed to 1
jimczi Mar 21, 2025
38137c5
fix test
jimczi Mar 21, 2025
5558bac
Merge remote-tracking branch 'upstream/main' into zstd_best_speed_com…
jimczi Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/index/codec/zstd/Zstd814StoredFieldsFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public final class Zstd814StoredFieldsFormat extends Lucene90CompressingStoredFi
public static final String MODE_KEY = Zstd814StoredFieldsFormat.class.getSimpleName() + ".mode";

public enum Mode {
BEST_SPEED(0, BEST_SPEED_BLOCK_SIZE, 128),
BEST_SPEED(1, BEST_SPEED_BLOCK_SIZE, 128),
BEST_COMPRESSION(3, BEST_COMPRESSION_BLOCK_SIZE, 2048);

final int level, blockSizeInBytes, blockDocCount;
Expand Down
2 changes: 1 addition & 1 deletion server/src/test/java/org/elasticsearch/index/codec/CodecTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void testDefault() throws Exception {
assumeTrue("Only when zstd_stored_fields feature flag is enabled", CodecService.ZSTD_STORED_FIELDS_FEATURE_FLAG.isEnabled());
Codec codec = createCodecService().codec("default");
assertEquals(
"Zstd814StoredFieldsFormat(compressionMode=ZSTD(level=0), chunkSize=14336, maxDocsPerChunk=128, blockShift=10)",
"Zstd814StoredFieldsFormat(compressionMode=ZSTD(level=1), chunkSize=14336, maxDocsPerChunk=128, blockShift=10)",
codec.storedFieldsFormat().toString()
);
}
Expand Down