Exercise multi-part uploads in S3 repo analysis tests #125669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the max blob size to 10MiB, and sets the buffer size to 5MiB, to ensure that sometimes the S3 repo analysis tests will create blobs using the multipart upload flow.
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
added
the
auto-backport
mhl-b
reviewed
Mar 26, 2025
| request.addParameter("blob_count", "10"); | ||
| request.addParameter("concurrency", "4"); | ||
| request.addParameter("max_blob_size", "1mb"); | ||
| request.addParameter("max_blob_size", randomFrom("1mb", "10mb")); |
There was a problem hiding this comment.
Can you use actual value from the repositorySettings? Hard to guess relationship between those two.
There was a problem hiding this comment.
This is abstract so no we can't see anything S3-specific here.
DiannaHohensee
approved these changes
Mar 26, 2025
| request.addParameter("blob_count", "10"); | ||
| request.addParameter("concurrency", "4"); | ||
| request.addParameter("max_blob_size", "1mb"); | ||
| request.addParameter("max_blob_size", randomFrom("1mb", "10mb")); |
There was a problem hiding this comment.
is it worth increasing the range to 15 or 20? To get more than 2 chunks?
There was a problem hiding this comment.
2 is enough, I can't really see how we could get this right with 2 chunks but wrong with more.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 26, 2025
Extends the max blob size to 10MiB, and sets the buffer size to 5MiB, to ensure that sometimes the S3 repo analysis tests will create blobs using the multipart upload flow.
💚 Backport successful
|
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Extends the max blob size to 10MiB, and sets the buffer size to 5MiB, to ensure that sometimes the S3 repo analysis tests will create blobs using the multipart upload flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the max blob size to 10MiB, and sets the buffer size to 5MiB, to
ensure that sometimes the S3 repo analysis tests will create blobs using
the multipart upload flow.