Fix p0=deprecation/10_basic/Test Deprecations
#125687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>test
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
reviewed
Mar 26, 2025
muted-tests.yml
Outdated
Comment on lines
390
to
392
| - class: org.elasticsearch.xpack.test.rest.XPackRestIT | ||
| method: test {p0=deprecation/10_basic/Test Deprecations} | ||
| issue: https://github.com/elastic/elasticsearch/issues/123147 |
There was a problem hiding this comment.
I actually just opened #125682 to address the failing tests from that issue. The failure issue only references V7 compat tests, which will be fixed by my PR. We need a different fix for main. The fix is to specify index: "*,-.security*" here:
Could you make that change instead of muting it in this PR, please? Sorry for not mentioning that earlier, I was trying to do too many things at the same time...
There was a problem hiding this comment.
Done, let's see if it passes.
There was a problem hiding this comment.
Also thanks for fixing. I am wondering though if this is a fix or a workaround. What do you think?
There was a problem hiding this comment.
Talked offline and checked the proxy logs to see how it's used. We decided to anticipate the warning because the API is mainly used in this way GET /_migration/deprecations.
gmarouli
added
the
auto-backport
nielsbauman
approved these changes
Mar 27, 2025
gmarouli
added
the
auto-merge-without-approval
|
Thanks for all the help @nielsbauman |
This was referenced Mar 27, 2025
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Mar 27, 2025
In elastic#120505 we introduced a capabilities check in the yaml test `deprecation/10_basic/Test Deprecations` but we forgot to add them in the `RestDeprecationInfoAction`. In this PR we add the capabilities which will enable the test and we make the test resilient to the warning that occurs when the `.security-7` index is present.
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Mar 27, 2025
In elastic#120505 we introduced a capabilities check in the yaml test `deprecation/10_basic/Test Deprecations` but we forgot to add them in the `RestDeprecationInfoAction`. In this PR we add the capabilities which will enable the test and we make the test resilient to the warning that occurs when the `.security-7` index is present.
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Mar 27, 2025
In elastic#120505 we introduced a capabilities check in the yaml test `deprecation/10_basic/Test Deprecations` but we forgot to add them in the `RestDeprecationInfoAction`. In this PR we add the capabilities which will enable the test and we make the test resilient to the warning that occurs when the `.security-7` index is present.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
In #120505 we introduced a capabilities check in the yaml test `deprecation/10_basic/Test Deprecations` but we forgot to add them in the `RestDeprecationInfoAction`. In this PR we add the capabilities which will enable the test and we make the test resilient to the warning that occurs when the `.security-7` index is present.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
In #120505 we introduced a capabilities check in the yaml test `deprecation/10_basic/Test Deprecations` but we forgot to add them in the `RestDeprecationInfoAction`. In this PR we add the capabilities which will enable the test and we make the test resilient to the warning that occurs when the `.security-7` index is present.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
In #120505 we introduced a capabilities check in the yaml test `deprecation/10_basic/Test Deprecations` but we forgot to add them in the `RestDeprecationInfoAction`. In this PR we add the capabilities which will enable the test and we make the test resilient to the warning that occurs when the `.security-7` index is present.
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
In elastic#120505 we introduced a capabilities check in the yaml test `deprecation/10_basic/Test Deprecations` but we forgot to add them in the `RestDeprecationInfoAction`. In this PR we add the capabilities which will enable the test and we make the test resilient to the warning that occurs when the `.security-7` index is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #120505 we introduced a capabilities check in the yaml test
deprecation/10_basic/Test Deprecationsbut we forgot to add them in theRestDeprecationInfoAction.In this PR we add the capabilities which will enable the test and we make the test resilient to the warning that occurs when the
.security-7index is present.