Skip to content

Fix p0=deprecation/10_basic/Test Deprecations #125687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 27, 2025
Merged

Fix p0=deprecation/10_basic/Test Deprecations #125687

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
741987c
Add missing capabilities to the deprecation API
gmarouli Mar 26, 2025
93933c9
Mute it because of #123147
gmarouli Mar 26, 2025
2b2b447
Merge branch 'main' into fix-missing-capacity
gmarouli Mar 26, 2025
ea13aa5
Update test
gmarouli Mar 27, 2025
fd66d09
Merge branch 'main' into fix-missing-capacity
gmarouli Mar 27, 2025
a2133d9
Anticipate the warning
gmarouli Mar 27, 2025
08c958d
Use `allowed_warnings` instead or `warnings`
gmarouli Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,9 @@ tests:
- class: org.elasticsearch.xpack.ilm.actions.SearchableSnapshotActionIT
method: testSearchableSnapshotsInHotPhasePinnedToHotNodes
issue: https://github.com/elastic/elasticsearch/issues/125683
- class: org.elasticsearch.xpack.test.rest.XPackRestIT
method: test {p0=deprecation/10_basic/Test Deprecations}
issue: https://github.com/elastic/elasticsearch/issues/123147
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just opened #125682 to address the failing tests from that issue. The failure issue only references V7 compat tests, which will be fixed by my PR. We need a different fix for main. The fix is to specify index: "*,-.security*" here:

elasticsearch/x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/deprecation/10_basic.yml

Line 18 in 540f90e

index: "*"

Could you make that change instead of muting it in this PR, please? Sorry for not mentioning that earlier, I was trying to do too many things at the same time...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, let's see if it passes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also thanks for fixing. I am wondering though if this is a fix or a workaround. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline and checked the proxy logs to see how it's used. We decided to anticipate the warning because the API is mainly used in this way GET /_migration/deprecations.


# Examples:
#
Expand Down
8 changes: 8 additions & 0 deletions ...recation/src/main/java/org/elasticsearch/xpack/deprecation/RestDeprecationInfoAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,14 @@

import java.io.IOException;
import java.util.List;
import java.util.Set;

import static org.elasticsearch.rest.RestRequest.Method.GET;

public class RestDeprecationInfoAction extends BaseRestHandler {

private static final Set<String> SUPPORTED_CAPABILITIES = Set.of("data_streams", "ilm_policies", "templates");

@Override
public List<Route> routes() {
return List.of(new Route(GET, "/_migration/deprecations"), new Route(GET, "/{index}/_migration/deprecations"));
Expand All @@ -47,4 +50,9 @@ private static RestChannelConsumer handleGet(final RestRequest request, NodeClie
);
return channel -> client.execute(DeprecationInfoAction.INSTANCE, infoRequest, new RestToXContentListener<>(channel));
}

@Override
public Set<String> supportedCapabilities() {
return SUPPORTED_CAPABILITIES;
}
}