Address precision issue in IndexDiskUsageAnalyzerTests#testCompletionFields #125849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fields We have some tolerance wound how many bytes we report for these completion fields. But the values depend on the distribution of the random values that determine how many docs get an option field. This commit makes the test more precise by computing the real ratio between docs that have the optional field and the total number of docs, so that we can base assertion on more realistic expectations. Closes elastic#123269
javanna
added
>test
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
reviewed
Mar 31, 2025
.../test/java/org/elasticsearch/action/admin/indices/diskusage/IndexDiskUsageAnalyzerTests.java
Show resolved
Hide resolved
javanna
added
the
auto-backport
|
Thanks @drempapis ! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
…Fields (#125849) (#125951) We have some tolerance wound how many bytes we report for these completion fields. But the values depend on the distribution of the random values that determine how many docs get an option field. This commit makes the test more precise by computing the real ratio between docs that have the optional field and the total number of docs, so that we can base assertion on more realistic expectations. Closes #123269
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 31, 2025
…Fields (elastic#125849) (elastic#125951) We have some tolerance wound how many bytes we report for these completion fields. But the values depend on the distribution of the random values that determine how many docs get an option field. This commit makes the test more precise by computing the real ratio between docs that have the optional field and the total number of docs, so that we can base assertion on more realistic expectations. Closes elastic#123269
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
…Fields (#125849) (#125951) (#125963) We have some tolerance wound how many bytes we report for these completion fields. But the values depend on the distribution of the random values that determine how many docs get an option field. This commit makes the test more precise by computing the real ratio between docs that have the optional field and the total number of docs, so that we can base assertion on more realistic expectations. Closes #123269
javanna
added a commit
that referenced
this pull request
Apr 1, 2025
…Fields (#125849) (#125951) (#125962) We have some tolerance wound how many bytes we report for these completion fields. But the values depend on the distribution of the random values that determine how many docs get an option field. This commit makes the test more precise by computing the real ratio between docs that have the optional field and the total number of docs, so that we can base assertion on more realistic expectations. Closes #123269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some tolerance wound how many bytes we report for these completion fields. But the values depend on the distribution of the random values that determine how many docs get an option field. This commit makes the test more precise by computing the real ratio between docs that have the optional field and the total number of docs, so that we can base assertion on more realistic expectations.
This is a pretty rare failure that happened so far only in main, but it reproduces in 8.x as well, hence I suggest we backport the fix.
Closes #123269