Skip to content

Address precision issue in IndexDiskUsageAnalyzerTests#testCompletionFields #125849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Address precision issue in IndexDiskUsageAnalyzerTests#testCompletionFields #125849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,6 @@ tests:
- class: org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT
method: testHistoryIsWrittenWithFailure
issue: https://github.com/elastic/elasticsearch/issues/123203
- class: org.elasticsearch.action.admin.indices.diskusage.IndexDiskUsageAnalyzerTests
method: testCompletionField
issue: https://github.com/elastic/elasticsearch/issues/123269
- class: org.elasticsearch.packaging.test.DockerTests
method: test151MachineDependentHeapWithSizeOverride
issue: https://github.com/elastic/elasticsearch/issues/123437
Expand Down
8 changes: 6 additions & 2 deletions ...st/java/org/elasticsearch/action/admin/indices/diskusage/IndexDiskUsageAnalyzerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,23 +339,27 @@ public PostingsFormat getPostingsFormatForField(String field) {
});

try (Directory dir = createNewDirectory()) {
float docsWithSuggest1FieldRatio;
try (IndexWriter writer = new IndexWriter(dir, config)) {
int numDocs = randomIntBetween(100, 1000);
int numDocsWithSuggest1Field = 0;
for (int i = 0; i < numDocs; i++) {
final Document doc = new Document();
if (randomDouble() < 0.5) {
numDocsWithSuggest1Field++;
doc.add(new SuggestField("suggest_1", randomAlphaOfLength(10), randomIntBetween(1, 20)));
}
doc.add(new SuggestField("suggest_2", randomAlphaOfLength(10), randomIntBetween(1, 20)));
writer.addDocument(doc);
}
docsWithSuggest1FieldRatio = (float) numDocsWithSuggest1Field / (numDocs + numDocsWithSuggest1Field);
}
final IndexDiskUsageStats stats = IndexDiskUsageAnalyzer.analyze(testShardId(), lastCommit(dir), () -> {});
assertFieldStats(
"suggest_1",
"inverted_index",
stats.getFields().get("suggest_1").getInvertedIndexBytes(),
stats.total().totalBytes() / 3,
(long) (stats.total().totalBytes() * docsWithSuggest1FieldRatio),
0.05,
2048
);
Expand All @@ -364,7 +368,7 @@ public PostingsFormat getPostingsFormatForField(String field) {
"suggest_2",
"inverted_index",
stats.getFields().get("suggest_2").getInvertedIndexBytes(),
stats.total().totalBytes() * 2 / 3,
(long) (stats.total().totalBytes() * (1 - docsWithSuggest1FieldRatio)),
0.05,
2048
);
Expand Down