Skip to content

Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging #125884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging #125884

merged 2 commits into from
Mar 31, 2025

Conversation

@masseyke
Copy link
Member

EnterpriseGeoIpDownloaderIT has been muted for some time because of what appears to be a rare race condition (#115163). In the meantime it seems to have decayed more. This PR re-enables the test with verbose logging for DatabaseNodeService to help troubleshoot the rare race condition. I also had to fix a few other things that (probably) changed due to test mmdb file updates.
Closes #115163

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP auto-backport Automatically create backport pull requests when merged v8.19.0 v9.0.1 v9.1.0 labels Mar 28, 2025
@masseyke masseyke requested a review from joegallo March 28, 2025 18:26
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Mar 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

joegallo
joegallo approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@masseyke masseyke merged commit 939dc8b into elastic:main Mar 31, 2025
17 checks passed
@masseyke masseyke deleted the re-enable-EnterpriseGeoIpDownloaderIT branch March 31, 2025 14:49
@masseyke masseyke mentioned this pull request Mar 31, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
✅ 9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125884

masseyke added a commit to masseyke/elasticsearch that referenced this pull request Mar 31, 2025
@masseyke
Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging (elastic…
68b73cb 
…#125884)
@masseyke
Copy link
Member Author

💔 Some backports could not be created

Status Branch Result
❌ 8.x Conflict resolution was aborted by the user
✅ 8.18

Manual backport

To create the backport manually run:

backport --pr 125884

Questions ?

Please refer to the Backport tool documentation

@masseyke masseyke mentioned this pull request Mar 31, 2025
Merged
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Mar 31, 2025
@masseyke
Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging (elastic…
71a85a7 
…#125884)

(cherry picked from commit 939dc8b)

# Conflicts:
#	muted-tests.yml
@masseyke
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

@masseyke masseyke mentioned this pull request Mar 31, 2025
Merged
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Mar 31, 2025
@masseyke
Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging (elastic…
ea25f9b 
…#125884)

(cherry picked from commit 939dc8b)

# Conflicts:
#	muted-tests.yml
masseyke added a commit that referenced this pull request Mar 31, 2025
@masseyke
Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging (#125884) (
f6c9882 
#125966)
elasticsearchmachine pushed a commit that referenced this pull request Mar 31, 2025
@masseyke
[9.0] Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging (#…
50579d3 
…125884) (#125957)

* Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging (#125884)

* Changing expected values to match those in the mmdb files before #122225
masseyke added a commit that referenced this pull request Mar 31, 2025
@masseyke
[8.18] Re-enabling EnterpriseGeoIpDownloaderIT with verbose logging (#…
9a6b47b 
…125884) (#125965)
@nielsbauman nielsbauman mentioned this pull request Apr 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joegallo joegallo joegallo approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] EnterpriseGeoIpDownloaderIT testEnterpriseDownloaderTask failing

3 participants

@masseyke @elasticsearchmachine @joegallo